remove async from trustroot trait #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `sigstore::trust::sigstore::SigstoreTrustRoot` can hold multiple Rekor keys. The possibility to have multiple keys is also reflected by the [`sigstore::trust::TrustRoot.rekor_keys`](https://docs.rs/sigstore/0.9.0/sigstore/trust/trait.TrustRoot.html#tymethod.rekor_keys) trait. This commit allows the `ManualTrustRoot` object to hold multiple Rekor keys. Signed-off-by: Flavio Castelli <[email protected]>
Allow to create `static` instances of the `cosign::Client`, `sigstore::trust::ManualTrustRoot`. The ability to create `static` instances of these objects can simplify the downstream consumers of this library. The approach taken to create these `static` instance is the same used by [`rustls_pki_types::CertificateDer::into_owned`](https://docs.rs/rustls-pki-types/1.4.1/rustls_pki_types/struct.CertificateDer.html#method.into_owned) Signed-off-by: Flavio Castelli <[email protected]>
Make the `sigstore::trust::TrustRoot` methods not async. Fixes sigstore#346 Signed-off-by: Flavio Castelli <[email protected]>
|
Closing, this is done as part of #311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR builds on top of #348 and #349. I'll rebase it once those are merged.
This PR makes the methods defined inside of the
sigstore::trust::TrustRoottrait non-async. This fixes #346